-
Notifications
You must be signed in to change notification settings - Fork 51
fix: source mapping original path instead of user-provided input #978
Conversation
Codecov Report
@@ Coverage Diff @@
## master #978 +/- ##
=======================================
Coverage 66.78% 66.78%
=======================================
Files 20 20
Lines 1668 1668
Branches 340 340
=======================================
Hits 1114 1114
Misses 475 475
Partials 79 79
Continue to review full report at Codecov.
|
src/agent/io/sourcemapper.ts
Outdated
* @constructor | ||
*/ | ||
constructor() { | ||
constructor(readonly logger: Logger) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Private constructor?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The create() function is actually not a static function of this class, marking the constructor as private will change the usage of this function in all places. I think for this PR, it is better to keep it as it is, what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from a TypeScript perspective
…-nodejs into nodejs-agent-srcmap
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small change to make, but looks good.
🤖 I have created a release \*beep\* \*boop\* --- ### [5.2.5](https://www.github.com/googleapis/cloud-debug-nodejs/compare/v5.2.4...v5.2.5) (2021-06-24) ### Bug Fixes * Add debugging information for sourcemapper ([#977](https://www.github.com/googleapis/cloud-debug-nodejs/issues/977)) ([b647106](https://www.github.com/googleapis/cloud-debug-nodejs/commit/b6471062a24894c7a427ad29ece0819b3b383352)) * source mapping original path instead of user-provided input ([#978](https://www.github.com/googleapis/cloud-debug-nodejs/issues/978)) ([108225c](https://www.github.com/googleapis/cloud-debug-nodejs/commit/108225cfadbef2c6b3b0c4f4be06a8ea983a0476)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Uses the original source path in the mapInfo instead of user-provided input to check the generated sources, so that when the user provided a partial match of the file, we can still correctly map the original file to the generated file.
This PR is based on PR #977
Fixes #963