This repository has been archived by the owner on Apr 3, 2024. It is now read-only.
fix: surface correct error message for ambiguous sourcemap matches #971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: clouddebugger
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #971 +/- ##
==========================================
+ Coverage 66.50% 66.54% +0.04%
==========================================
Files 20 20
Lines 1645 1656 +11
Branches 339 340 +1
==========================================
+ Hits 1094 1102 +8
- Misses 473 475 +2
- Partials 78 79 +1
Continue to review full report at Codecov.
|
JustinBeckwith
approved these changes
Jun 9, 2021
mctavish
approved these changes
Jun 14, 2021
| @@ -26,12 +26,25 @@ const readFilep = promisify(fs.readFile); | |||
|
|
|||
| /** @define {string} */ const MAP_EXT = '.map'; | |||
|
|
|||
| /** Represents one source map file. */ | |||
There was a problem hiding this comment.
Thank you so much for this documentation!
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jun 14, 2021
🤖 I have created a release \*beep\* \*boop\* --- ### [5.2.3](https://www.github.com/googleapis/cloud-debug-nodejs/compare/v5.2.2...v5.2.3) (2021-06-14) ### Bug Fixes * surface correct error message for ambiguous sourcemap matches ([#971](https://www.github.com/googleapis/cloud-debug-nodejs/issues/971)) ([d5abfac](https://www.github.com/googleapis/cloud-debug-nodejs/commit/d5abfac3affba586f7fa28d2388a2b1d15942576)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #961