This repository has been archived by the owner on Apr 3, 2024. It is now read-only.
build!: update to latest gts and TypeScript #851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
AVaksman
force-pushed
the
update_gts-typescript
branch
2 times, most recently
from
6836c05
to
c2e0eec
Compare
AVaksman
added
the
kokoro:force-run
AVaksman
force-pushed
the
update_gts-typescript
branch
from
c2e0eec
to
0da1ea5
Compare
yoshi-kokoro
removed
the
kokoro:force-run
JustinBeckwith
suggested changes
Apr 11, 2020
.eslintignore
Outdated
| @@ -3,3 +3,6 @@ src/**/doc/* | |||
| build/ | |||
| docs/ | |||
| protos/ | |||
| test/fixtures/fib.js | |||
There was a problem hiding this comment.
Instead of calling these out individually, add test/fixtures and ignore the whole dir
There was a problem hiding this comment.
Added
test/fixtures
system-test/fixtures
Thanks
package.json
Outdated
| @@ -75,7 +75,7 @@ | |||
| "cpy-cli": "^3.1.0", | |||
| "cross-env": "^7.0.0", | |||
| "execa": "^4.0.0", | |||
| "gts": "^1.0.0", | |||
| "gts": "^2.0.0-alpha.8", | |||
There was a problem hiding this comment.
Please use ^2.0.0 :)
There was a problem hiding this comment.
Fixed here and in system-test
Thanks
samples/test/test.js
Outdated
| @@ -14,17 +14,19 @@ | |||
|
|
|||
| 'use strict'; | |||
|
|
|||
| // eslint-disable-next-line node/no-unpublished-require | |||
There was a problem hiding this comment.
This looks like a bug in samples/package.json. Can you make sure the files property is set in that file? We shouldn't need this exclusion rule.
There was a problem hiding this comment.
added
"files": [
"*.js"
]
Thanks
src/agent/state/legacy-state.ts
Outdated
| @@ -40,9 +40,11 @@ export function evaluate( | |||
| frame: v8.FrameMirror | |||
| ): {error: string | null; mirror?: v8.ValueMirror} { | |||
| // First validate the expression to make sure it doesn't mutate state | |||
| // eslint-disable-next-line @typescript-eslint/no-var-requires | |||
There was a problem hiding this comment.
Instead of this, could you install @types/acorn and use that?
There was a problem hiding this comment.
used import * as acorn from 'acorn';
Thanks
| @@ -14,8 +14,8 @@ | |||
| "@google-cloud/debug-agent": "./debug.tgz" | |||
| }, | |||
| "devDependencies": { | |||
| "gts": "^1.1.0", | |||
| "typescript": "~3.7.0", | |||
| "gts": "^2.0.0-alpha.8", | |||
1 task
| var i = 1; | ||
| var foo = function foo(j) { | ||
| return i + j + "hi"; | ||
| 'use strict'; |
There was a problem hiding this comment.
If you get test failures, first place I'd look is rolling back changes to fixtures (otherwise this is fine)
There was a problem hiding this comment.
Thanks, I was looking out for the same thing. Looks like so far everything is green.
JustinBeckwith
approved these changes
Apr 14, 2020
Merged
yoshi-automation
added a commit
that referenced
this pull request
Apr 15, 2020
yoshi-automation
added a commit
that referenced
this pull request
Apr 16, 2020
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jun 4, 2020
🤖 I have created a release \*beep\* \*boop\* --- ## [5.0.0](https://www.github.com/googleapis/cloud-debug-nodejs/compare/v4.2.2...v5.0.0) (2020-05-20) ### ⚠ BREAKING CHANGES * drop support for node.js 8.x (#851) * require node 10 in engines field (#852) ### Features * require node 10 in engines field ([#852](https://www.github.com/googleapis/cloud-debug-nodejs/issues/852)) ([01dc0e2](https://www.github.com/googleapis/cloud-debug-nodejs/commit/01dc0e263a57914e7f7320feac950dfedeeb7099)) ### Bug Fixes * **deps:** update dependency @google-cloud/common to v3 ([#853](https://www.github.com/googleapis/cloud-debug-nodejs/issues/853)) ([79bbc9c](https://www.github.com/googleapis/cloud-debug-nodejs/commit/79bbc9c9ad9c763166e6a96ba254c8521d485f12)) * **deps:** update dependency gcp-metadata to v4 ([#844](https://www.github.com/googleapis/cloud-debug-nodejs/issues/844)) ([8b4040e](https://www.github.com/googleapis/cloud-debug-nodejs/commit/8b4040e933676535fb75c135be931c70fc8bad37)) * apache license URL ([#468](https://www.github.com/googleapis/cloud-debug-nodejs/issues/468)) ([#863](https://www.github.com/googleapis/cloud-debug-nodejs/issues/863)) ([87553b2](https://www.github.com/googleapis/cloud-debug-nodejs/commit/87553b267df9e0008584645a80c41ef820c11689)) * reduce set of dependencies ([#876](https://www.github.com/googleapis/cloud-debug-nodejs/issues/876)) ([6c2722e](https://www.github.com/googleapis/cloud-debug-nodejs/commit/6c2722e59bb7113cf7a4bf065434b2be3aff50ca)) ### Build System * drop support for node.js 8.x ([#851](https://www.github.com/googleapis/cloud-debug-nodejs/issues/851)) ([3130ad3](https://www.github.com/googleapis/cloud-debug-nodejs/commit/3130ad320dc69b01d43d8e39d31ce158a13311f1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: typescript 3.7.x introduced breaking changes in the generated code.