Expand google-api-core pin to >1, <3
#473
Conversation
To avoid diamond dependency conflicts with Cloud libraries, the Ads library should keep a `>1, <3` pin on google-api-core until googleapis/google-cloud-python#10566 is closed. See discussion in [doc](https://docs.google.com/document/d/1euAvUsia_4zf98lNvpwA3K0o2b4y5Xr9xAkyzCnIMzQ/edit#).
|
I see the doc, but it is unclear what the consequences of expanding this to
3.0.0 is.
…On Wed, Jul 28, 2021, 5:50 PM Bu Sun Kim ***@***.***> wrote:
@busunkim96 <https://github.com/busunkim96> requested review from
@googleads/google-ads-python-codereview on: #473
<#473> Expand google-api-core
pin to >1, <3 as a code owner.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#473 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABCOJCGMLP2HJK5WY3PKBR3T2B3RHANCNFSM5BFGL6WA>
.
|
|
Ah sorry, here's some more context:
The particular situation this PR is looking to prevent is one where some customer who uses both On the Cloud side, we're doing this range expansion before the If you all would be more comfortable waiting until |
|
Hi Bu,
I read the document and understood the diamond dependency issue. That LGTM
in terms of the proposed approach.
We have a very large scale migration going on right now. Any bugs /
performance regressions introduced in google-api-core 2.0.0 will have a
much worse outcome than the diamond dependency issue we are talking about
here. Happy to share details offline.
Out of abundance of caution, our recommendation is to kindly pause your
release until we run this new library version internally against our
internal benchmarks and tests to ensure that nothing blows up.
Kindly start an internal email thread with me, and Ben Karl, feel free to
cc Dan/Justin. We will loop in more folks as needed and will try to unblock
you ASAP.
…On Wed, Jul 28, 2021, 7:32 PM Bu Sun Kim ***@***.***> wrote:
Ah sorry, here's some more context:
google-api-core is planning on officially dropping 2.7 in a new major
release (2.0.0).
The particular situation this PR is looking to prevent is one where some
customer who uses bothgoogle-ads and a Google Cloud library sees a
diamond dependency conflict. As an example, if some recent release of
google-ads wants google-api-core>1.x.x, <2.0.0dev and some recent release
of google-cloud-bigquery wants google-api-core>2.x.x, <3.0.0dev pip will
not be able to find a version of google-api-core that satisfies both and
raise an error.
On the Cloud side, we're doing this range expansion before the
google-api-core release to increase the amount of time / # of versions
published with compatible pins. The hope is that this decreases the
likelihood end users of these libraries see dependency conflicts.
If you all would be more comfortable waiting until google-api-core 2.0.0
is released to take this change that is also OK.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#473 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABCOJCG756B42SUCOTMT26TT2CHQFANCNFSM5BFGL6WA>
.
|
|
Hi Anash! One more important note: there are no major bug fixes/ performance changes planned for google-api-core 2.0.0, it is intended to just be a removal of python 2.7. You can review the currently open PR: googleapis/python-api-core#212. I've also started an email thread to go into details. |
|
Closing this because we're going to submit it via our internal code review process. |
To avoid diamond dependency conflicts with Cloud libraries, the Ads library should keep a
>1, <3pin on google-api-core until googleapis/google-cloud-python#10566 is closed.See discussion in doc.
CC @BenRKarl