Remove compatibility overrides for protobuf error collectors after update of grpc/protobuf #1408
Labels
code-maintenance
Everything w.r.t. code quality, maintenance, TODOs
Comments
hzeller
added
the
code-maintenance
copybara-service bot
pushed a commit
that referenced
this issue
May 15, 2024
The protobuffer error collector interfaces changed to accept string_views instead. Since these are virtual methods, we need to override both in the transition period (but not add any 'override' to it as this depends on the available version we override). Once we are on latest protobuf (i.e. once we can update grpc), this will automatically compile with the new version. After that, we can remove the old AddError()/AddWarning() methods. Issues: #1408 PiperOrigin-RevId: 634099367
|
It looks like the c++20 issue in question is fixed upstream in grpc, now we just need to wait for it to be backported to then integrate 1.64.x (x > 0). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The classes that act as
ErrorCollectorfor protocol buffer changed the interface; Currently they are formulated so that they work with old and new protocol buffer versions, which is needed until we've updated grpc (which is also providing the protocol buffer dependencey; GRPC update is currently stuck on grpc/grpc#36132 ).The files in question are
They have
TODOs pointing to this issue.After grpc is updated, fix these TODOs.
The text was updated successfully, but these errors were encountered: