Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor out FIFO state in block evaluators #1389

Open
grebe opened this issue Apr 19, 2024 · 0 comments
Open

Factor out FIFO state in block evaluators #1389

grebe opened this issue Apr 19, 2024 · 0 comments
Labels
enhancement New feature or request jit

Comments

@grebe
Copy link
Collaborator

grebe commented Apr 19, 2024

In a current WiP change, I'm putting FIFO state in the register state map. This is convenient and avoids the need for API changes, but has some shortcomings.

Long term, it seems better to factor out FIFO state. Some benefits:

  • Initializing registers is already clunky and the current approach makes it worse.
  • Using std::deque or circular buffer is more performant.
  • Factoring state out may make it easier to share FIFO implementation w/ the JIT.
@grebe grebe added enhancement New feature or request jit labels Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request jit
Projects
None yet
Development

No branches or pull requests

1 participant