Add a reflective field equality based subject and correspondence. #606
Conversation
This is written in Kotlin and depends on kotlin runtime as a result, however is designed to work cleanly from Java, and its kotlin origins should not be paritcularly noticeable to the test-writing developer. The tests handle single object testing (via the Subject) and list element comparisons using a Correspondence. Field comparisons can be shallow or deep, and can respect (in the deep case) declared `equals()` methods or ignore them. It also can handle reference cycles (with caveats). This is upstreamed from Square, Inc. and licensed under Apache 2.0.
cgruber
force-pushed
the
reflective_fields
branch
from
85006c1
to
1fef263
Compare
|
Ping @cpovirk. :) (No rush if you're busy, but wanted to make sure it didn't fall in the cracks. |
|
Sorry. It's on The List; things have just been crazier than expected lately. |
|
No worries. :) |
|
Hey @cpovirk - was just showing how github worked to a friend, and realized I have this Pr still hanging on. Any thoughts around moving it forward? |
|
Sorry again. You can see how badly I estimated how much we'd be able to do with Truth in the months following the 1.0 release. I am probably never going to review this as thoroughly as I'd hoped, but given that you've found it useful, I don't see a reason to let that block things. I will try harder to have a reasonable but less thorough look in the next couple weeks. One thing I should check with you on: It looks like you're versioning this with the rest of Truth. So it will appear in 1.1, etc. Do you think that's OK, especially given that we're intending not to make breaking changes to Truth (and thus ideally wouldn't make them to this, either, since that would push us to Truth 2.0)? Or maybe it's fine to start by following Truth but then have Truth and your extension diverge in version numbers if you later want to make a breaking change? |
This is written in Kotlin and depends on kotlin runtime as a result, however is designed to work cleanly from Java, and its kotlin origins should not be paritcularly noticeable to the test-writing developer.
The tests handle single object testing (via the Subject) and list element comparisons using a Correspondence. Field comparisons can be shallow or deep, and can respect (in the deep case) declared
equals()methods or ignore them. It also can handle reference cycles (with caveats).This is upstreamed from Square, Inc. and licensed under Apache 2.0.
Addresses #560