Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOM text reinterpreted as HTML Update inject.js #262

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Shivam7-1
Copy link

By using innerText, it will avoid the risk of HTML injection, as these properties automatically escape any HTML special characters in the provided text. This helps prevent cross-site scripting (XSS) vulnerabilities by treating the input as plain text rather than interpreted HTML. Always be cautious when dealing with user input or dynamic content to prevent security risks.

@Shivam7-1
Copy link
Author

Hi @sirdarckcat Could You Please Review this PR
Thanks

@Shivam7-1
Copy link
Author

Hi @sirdarckcat Could You Please Review this PR
Thanks

@NeilFraser
Copy link
Member

In this case innerHTML is being used as a getter, not a setter, so the existing code is perfectly safe. Further, it appears that changing this to text-only would break the following match, which seems to be looking for HTML attributes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants