Avoid IWYU warnings on other namespaces for <algorithm>. #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an extension of the logic already used for other STL headers.
ibrahimmemonn
approved these changes
Jan 3, 2023
|
I don't have permission to merge the PR; can you either merge it or grant me write access? |
I can't merge :( I don't have access but I'll request for it |
|
Hi, as far as I am aware, google does not accept PRs for cpplint anymore (since the google-internal cpplint supposedly has evolved a lot. However, this MR might be suitable for https://github.com/cpplint/cpplint, the pypi deployed fork which I have been maintaining. Would this also fix cpplint#200 ? |
|
I don't know offhand, but it might. You're welcome to merge this code into your fork if you wish. |
kbakdev
approved these changes
Feb 14, 2023
devvsakib
approved these changes
Feb 23, 2023
abeir
pushed a commit
to abeir/depot_tools
that referenced
this pull request
Apr 24, 2024
Cherry-pick of google/styleguide#722. Bug: chromium:1368812 Change-Id: I3a604ce2e617b3f145c02519ec3528bff22f691c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an extension of the logic already used for other STL headers.