Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/rules/rcx: update resistance-values #377

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

proppy
Copy link
Member

@proppy proppy commented Jul 1, 2022

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jul 1, 2022
Copy link
Collaborator

@RTimothyEdwards RTimothyEdwards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This corrects the main errors in the documentation. From what I have in the magic tech file, though, it appears that the entry for Nwell should be changed from 1700000 to 950000.

Also, the file should probably have some indication that the values are for the nominal process corner, as opposed to the low and high resistance corners. Ideally, all three values for low/nominal/high should be in the file, as well as values for the A and B process variants (A=original, B=ReRam).

@proppy
Copy link
Member Author

proppy commented Jul 6, 2022

This corrects the main errors in the documentation. From what I have in the magic tech file, though, it appears that the entry for Nwell should be changed from 1700000 to 950000.

@RTimothyEdwards can you also update the source spreadsheet (https://docs.google.com/spreadsheets/d/1oL6ldkQdLu-4FEQE0lX6BcgbqzYfNnd1XA8vERe0vpE/edit#gid=1059412464) as I'm importing the data from here.

@proppy
Copy link
Member Author

proppy commented Jul 6, 2022

Also, the file should probably have some indication that the values are for the nominal process corner, as opposed to the low and high resistance corners. Ideally, all three values for low/nominal/high should be in the file, as well as values for the A and B process variants (A=original, B=ReRam).

Do we have the data for A and B / various corners in another spreadsheet? or should we be sourcing it from https://github.com/RTimothyEdwards/open_pdks/blob/5ed94ffe0059046164bfb97f670fab648fa90602/sky130/magic/sky130.tech#L5202 instead?

Copy link
Contributor

@mithro mithro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get why this diff is showing as being so large? Is there a whitespace change or something?

Copy link
Contributor

@mithro mithro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be some unrelated whitespace changes happening here.

This is what the diff should look like;
image

@RTimothyEdwards
Copy link
Collaborator

@proppy : All data for variant B (ReRAM support) is derived from values for variant A by adjusting for the height difference of metals starting at metal2 (plus the via between metal1 and metal2 doubles in height and therefore doubles in resistance). I was hoping we could get measured values, but I suppose I should publish all values in the spreadsheet and make a note that they are simply derived values based on the known difference in the metal stack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please correct resistor values in the PDK documentation
3 participants