Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating issues, licensing, Readme #12

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

FeliciaG
Copy link
Collaborator

Fixes #10 , #11

Many of the hardcoded paths in issue #11 depend on user setup of other tools. These paths have just been commented to indicate the user needs to update to be compliant with their directory setup.

Readme has been updated to reference new documentation and refer to BAG as Berkeley Analog Generator

Tests are failing because bag_prim.cdl and bag_prim.scs are missing the copyright headers. However, these files are generated by scripts, so this test should be removed.

@mithro
Copy link
Contributor

mithro commented May 15, 2023

This branch has conflicts that must be resolved

@mithro
Copy link
Contributor

mithro commented May 15, 2023

Changes generally look okay. Will add comments when the conflict is resolved.

@mithro
Copy link
Contributor

mithro commented May 15, 2023

@FeliciaG Could you do a rebase rather than a merge?

@mithro
Copy link
Contributor

mithro commented May 16, 2023

Looks like you still did a merge rather than a rebase....

You want to do something like;

git remote add upstream git@github.com:google/skywater-pdk-libs-sky130_bag3_pr.git
git fetch upstream
git rebase --interactive upstream/master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix bag_submodules.yaml references to git@10.8.0.1
2 participants