Skip to content
This repository has been archived by the owner on Dec 29, 2022. It is now read-only.

Use a specified filename to store downloaded bleu script. #182

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wb14123
Copy link

@wb14123 wb14123 commented Apr 20, 2017

This patch can avoid generate lots of temp files for bleu script.

Because the training will take much time and count the bleu metrics many times, there will be lots of temp files after the training.

This can avoid generate lots of temp files.
@wb14123
Copy link
Author

wb14123 commented Apr 23, 2017

Hi, how is this PR going? I think this is really useful.

@amirj
Copy link
Contributor

amirj commented Apr 23, 2017

Why the script should download multiple-bleu.perl multiple times?

@wb14123
Copy link
Author

wb14123 commented Apr 24, 2017

I think with this we could make sure that we are using the newest version.

But in a single training, it is better to not download the script every time we need to count bleu score. However it is a little difficult to implement since we need to pass a flag to check if it is the first time to count it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants