Update pytype_runner.py - change escape_ninja_path to escape all the ninja path escape-needing characters #1608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ninja path escape-needing characters
rchen152
suggested changes
Apr 3, 2024
| Args: | ||
| path: The path. | ||
| """ | ||
| new_path = '' |
There was a problem hiding this comment.
Now that there are multiple special characters involved, I'd prefer to use re.sub to make the code more concise. This seems to work:
return re.sub(r'(?P<char>[\n :$])', r'$\g<char>', path)
(An import re line is also needed at the top of the file, of course.)
There was a problem hiding this comment.
re.sub(r'([\n :$])', r'$\1', path) also works equivalently, and reads slightly simpler, if you prefer that. (I don't feel strongly either way.)
rchen152
approved these changes
Apr 9, 2024
rchen152
pushed a commit
that referenced
this pull request
Apr 9, 2024
…ninja path escape-needing characters (#1608) This fixes #499. Unfortunately, I was not able to get pytype running on my machine, so this commit is just based on what seems like the right idea to me, and hopefully it can be verified to be correct by a maintainer and then merged. Resolves #1608 PiperOrigin-RevId: 623037901
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #499
Unfortunately, I was not able to get pytype running on my machine, so this commit is just based on what seems like the right idea to me, and hopefully it can be verified to be correct by a maintainer and then merged.