Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Get a list of all valid commands when writing --help #364

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Rohan-Salwan
Copy link

@dbieber
Copy link
Member

dbieber commented Dec 9, 2022

Note to self: This makes the change discussed at #225 (comment)

Copy link

@bwtaylor bwtaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comments on line 326-327 should be modified to say that we do want methods and properties of classes to be accessible so that --help can show them.

Copy link

@bwtaylor bwtaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will show class attributes that start with an _ , an inconsistency with how it works for objects. This can be easily fixed via:
return not name.startswith('_')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Author has signed CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get a list of all valid commands when writing --help
3 participants