Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@cbrochtrup Add FIRE_PAGER environment variable for PAGER functionality #337

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

cbrochtrup
Copy link

Implement this comment.

Fixes #188

@google-cla
Copy link

google-cla bot commented Apr 27, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no Author has not signed CLA label Apr 27, 2021
@cbrochtrup
Copy link
Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes Author has signed CLA and removed cla: no Author has not signed CLA labels Apr 27, 2021
fire/console/console_io.py Outdated Show resolved Hide resolved
@google-cla
Copy link

google-cla bot commented May 4, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no Author has not signed CLA and removed cla: yes Author has signed CLA labels May 4, 2021
@google-cla
Copy link

google-cla bot commented May 4, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@cbrochtrup
Copy link
Author

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

information_source Googlers: Go here for more info.

@claui, since I added your suggestion can you sign the CLA please 😄

@google-cla
Copy link

google-cla bot commented May 4, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@claui
Copy link

claui commented May 4, 2021

@googlebot I consent.

@google-cla
Copy link

google-cla bot commented May 4, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@claui
Copy link

claui commented May 4, 2021

@cbrochtrup I tried everything but it won’t let me. Google doesn’t like the email address GitHub has assigned to my suggestion.

Feel free to revert my suggestion and re-apply it yourself.

@google-cla google-cla bot added cla: yes Author has signed CLA and removed cla: no Author has not signed CLA labels May 7, 2021
@cbrochtrup
Copy link
Author

@cbrochtrup I tried everything but it won’t let me. Google doesn’t like the email address GitHub has assigned to my suggestion.

Feel free to revert my suggestion and re-apply it yourself.

Ah shoot, I'm sorry Google isn't accepting your cla. Thanks for your suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Author has signed CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to print help to std out
2 participants