Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added version tagging for master commits #141

Closed
wants to merge 8 commits into from

Conversation

Zozman
Copy link

@Zozman Zozman commented Nov 14, 2022

Currently, it is extremely difficult to audit changes in this repository due to the fact that there is no sort of tagging when code is committed to the master branch of this repository. Therefore there is no way to know what exact version of ngx_brotli your using when downloading from GitHub unless you use a SHA of some sort, which is unwieldy.

Therefore this PR adds a GitHub Action to update a tag on the repo every time a commit is made to master. That way there is a tag to reference on each change in master, allowing for easier audibility of the repository.

Also resolves issues pointed out around tagging in Issue #120.

@google-cla
Copy link

google-cla bot commented Nov 14, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@PDowney
Copy link

PDowney commented Nov 15, 2022

This is the #1 reason why I refuse to implement this module into my Nginx builds. Without some type of versioning control, it's a roll of the dice as to whether the version that you installed is stable. It probably doesn't matter too much anyway though, as this module hasn't been updated since April.

@Zozman
Copy link
Author

Zozman commented Jan 4, 2023

I've borked up the commit history on this branch so have re-submitted it with a much cleaner commit history in #144.

@Zozman Zozman closed this Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants