fix: ensure we receive all messages we expect #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After sending a message only a single call to `conn.Receive` is made which can cause messages to queue up in the receive buffer if not all messages can be returned at once. This causes `ENOBUFS` as the kernel is unable to write any further messages. This commit introduces a check that ensures we call `conn.Receive` as often as needed to get the right number of responses: one for acknowledgment and one for the echo. Resolves: google#235
|
I made this a draft because I noticed that it does not fix the issue in all scenarios. Running a loop with one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After sending a message only a single call to
conn.Receiveis made which can cause messages to queue up in the receive buffer if not all messages can be returned at once. This causesENOBUFSas the kernel is unable to write any further messages.This commit introduces a check that ensures we call
conn.Receiveas often as needed to get the right number of responses: one for acknowledgment and one for the echo.Resolves: #235