-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polish mediapy_examples notebook #43
Conversation
Thank you! I sent this for review |
@Conchylicultor Could you please have a look? Thanks. |
This was merged internally, but somehow copybara didn't push to github. Will investigate |
Sorry for the delay. Should be fixed once #46 is reviewed and merged internally |
PiperOrigin-RevId: 638219237
The other PR was marged but copybara didn't automatically close this PR. Otherwise, it looks the release failed with : https://github.com/google/mediapy/actions/runs/9284368143/job/25546671814
I'm not sure who own |
Last version was published. I think things are green again: https://github.com/google/mediapy/releases/tag/v1.2.1 |
Created a mediapy_examples.py file that mirrors the mediapy_examples.ipynb notebook (using jupytext).
Running lint tools on it suggested several small improvements.
Got the package to also work on sys.platform == 'win32'; this only involved updating one test.