Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish mediapy_examples notebook #43

Closed
wants to merge 3 commits into from
Closed

Polish mediapy_examples notebook #43

wants to merge 3 commits into from

Conversation

hhoppe
Copy link
Collaborator

@hhoppe hhoppe commented Feb 19, 2024

Created a mediapy_examples.py file that mirrors the mediapy_examples.ipynb notebook (using jupytext).
Running lint tools on it suggested several small improvements.

Got the package to also work on sys.platform == 'win32'; this only involved updating one test.

@Conchylicultor
Copy link
Member

Thank you! I sent this for review

@hhoppe hhoppe requested a review from hedpeter May 7, 2024 02:38
@hhoppe
Copy link
Collaborator Author

hhoppe commented May 25, 2024

@Conchylicultor Could you please have a look? Thanks.

@Conchylicultor
Copy link
Member

This was merged internally, but somehow copybara didn't push to github. Will investigate

copybara-service bot pushed a commit that referenced this pull request May 28, 2024
FUTURE_COPYBARA_INTEGRATE_REVIEW=#43 from hhoppe:main 58b8a07
PiperOrigin-RevId: 637894612
@copybara-service copybara-service bot mentioned this pull request May 28, 2024
copybara-service bot pushed a commit that referenced this pull request May 28, 2024
FUTURE_COPYBARA_INTEGRATE_REVIEW=#43 from hhoppe:main 58b8a07
PiperOrigin-RevId: 637894612
@Conchylicultor
Copy link
Member

Sorry for the delay. Should be fixed once #46 is reviewed and merged internally

copybara-service bot pushed a commit that referenced this pull request May 28, 2024
FUTURE_COPYBARA_INTEGRATE_REVIEW=#43 from hhoppe:main 58b8a07
PiperOrigin-RevId: 637894612
copybara-service bot pushed a commit that referenced this pull request May 29, 2024
FUTURE_COPYBARA_INTEGRATE_REVIEW=#43 from hhoppe:main 58b8a07
PiperOrigin-RevId: 637894612
copybara-service bot pushed a commit that referenced this pull request May 29, 2024
FUTURE_COPYBARA_INTEGRATE_REVIEW=#43 from hhoppe:main 58b8a07
PiperOrigin-RevId: 637894612
Conchylicultor added a commit that referenced this pull request May 29, 2024
PiperOrigin-RevId: 638219237
@Conchylicultor
Copy link
Member

The other PR was marged but copybara didn't automatically close this PR.

Otherwise, it looks the release failed with : https://github.com/google/mediapy/actions/runs/9284368143/job/25546671814

ERROR    HTTPError: 400 Bad Request from https://upload.pypi.org/legacy/        
         User 'mediapy-owners' does not have a verified primary email address.  
         Please add a verified primary email before attempting to upload to     
         PyPI. See https://pypi.org/help/#verified-email for more information.  

I'm not sure who own mediapy-owners. I tried to contact the group. I hope they still have access to the password

@Conchylicultor
Copy link
Member

Last version was published. I think things are green again: https://github.com/google/mediapy/releases/tag/v1.2.1

@hhoppe hhoppe closed this May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants