Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ROCm] Add float8_e4m3fnuz test #20880

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

Ruturaj4
Copy link
Contributor

No description provided.

Copy link

google-cla bot commented Apr 23, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@Ruturaj4
Copy link
Contributor Author

Ruturaj4 commented Apr 23, 2024

@jakevdp can you review this please

@jakevdp
Copy link
Collaborator

jakevdp commented Apr 23, 2024

Can you say more about why you want to enable this test? It's only testing dot_general with preferred_element_type – we do have other coverage for dot_general without this argument.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants