New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jax.scipy.stats: manually document functions to avoid scipy import #20847
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I skimmed the first few, but have the same comments on all.
Not sure if you want to address these or defer them to the future, but we could improve these docs a bit.
a: arraylike | ||
axis: optional integer. If not specified, the input array is flattened. | ||
ddof: integer, default=1. The degrees of freedom in the SEM computation. | ||
nan_policy: str, default="propagate". JAX supports only "propagate" and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double backticks here probably.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean around the string literals?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes.
7765d44
to
c0cd48a
Compare
d728c1e
to
ec17e1f
Compare
a: arraylike | ||
axis: optional integer. If not specified, the input array is flattened. | ||
ddof: integer, default=1. The degrees of freedom in the SEM computation. | ||
nan_policy: str, default="propagate". JAX supports only "propagate" and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes.
This lets us give more implementation-specific information, and lets us avoid a dependency on scipy. Related to #20799.