netstack: don't count PMTUD when detecting loss #10409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test/cl631967721
branch
4 times, most recently
from
5513e23
to
b302674
Compare
Throughput could be lowered by entering fast recovery unnecessarily. When a larger-than-MTU segment was retransmitted as multiple segments, loss detection could fire either because we hit the dupack threshold or RACK detected loss due to ACKs from retransmissions. RACK was more succeptible to this because it's better at detecting loss and can do so even without 3 dupacks. Thus it fell into this trap more often. Addresses #10344. PiperOrigin-RevId: 634071568
copybara-service
bot
force-pushed
the
test/cl631967721
branch
from
b302674
to
fe4459d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
netstack: don't count PMTUD when detecting loss
Throughput could be lowered by entering fast recovery unnecessarily. When a
larger-than-MTU segment was retransmitted as multiple segments, loss detection
could fire either because we hit the dupack threshold or RACK detected loss due
to ACKs from retransmissions.
RACK was more succeptible to this because it's better at detecting loss and can
do so even without 3 dupacks. Thus it fell into this trap more often.
Addresses #10344.