feat!: prefer single quotes if possible (#475)

google · Mar 31, 2020 · 39a2705 · 39a2705
1 parent f9b20a6
commit 39a2705
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 19 deletions.
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -16,7 +16,8 @@
     "prefer-const": "error",
     "eol-last": "error",
     "prefer-arrow-callback": "error",
-    "no-trailing-spaces": "error"
+    "no-trailing-spaces": "error",
+    "quotes": ["warn", "single", { "avoidEscape": true }]
   },
   "overrides": [
     {

diff --git a/src/clean.ts b/src/clean.ts
@@ -33,7 +33,7 @@ export async function clean(options: Options): Promise<boolean> {
     if (outDir === '.') {
       options.logger.error(
         `${chalk.red('ERROR:')} ${chalk.gray('compilerOptions.outDir')} ` +
-          `cannot use the value '.'.  That would delete all of our sources.`
+          'cannot use the value ".".  That would delete all of our sources.'
       );
       return false;
     }
@@ -45,7 +45,7 @@ export async function clean(options: Options): Promise<boolean> {
     options.logger.error(
       `${chalk.red('ERROR:')} The ${chalk.gray('clean')} command` +
         ` requires ${chalk.gray('compilerOptions.outDir')} to be defined in ` +
-        `tsconfig.json.`
+        'tsconfig.json.'
     );
     return false;
   }

diff --git a/src/init.ts b/src/init.ts
@@ -82,10 +82,10 @@ export async function addScripts(
   let edits = false;
   const pkgManager = getPkgManagerCommand(options.yarn);
   const scripts: Bag<string> = {
-    check: `gts check`,
+    check: 'gts check',
     clean: 'gts clean',
-    compile: `tsc`,
-    fix: `gts fix`,
+    compile: 'tsc',
+    fix: 'gts fix',
     prepare: `${pkgManager} run compile`,
     pretest: `${pkgManager} run compile`,
     posttest: `${pkgManager} run check`,
@@ -285,7 +285,7 @@ export async function init(options: Options): Promise<boolean> {
     }
     const generate = await query(
       `${chalk.bold('package.json')} does not exist.`,
-      `Generate`,
+      'Generate',
       true,
       options
     );

diff --git a/test/test-init.ts b/test/test-init.ts
@@ -84,13 +84,13 @@ describe('init', () => {
 
   it('addScripts should not edit existing scripts on no', async () => {
     const SCRIPTS = {
-      check: `fake check`,
+      check: 'fake check',
       clean: 'fake clean',
-      compile: `fake tsc`,
-      fix: `fake fix`,
-      prepare: `fake run compile`,
-      pretest: `fake run compile`,
-      posttest: `fake run check`,
+      compile: 'fake tsc',
+      fix: 'fake fix',
+      prepare: 'fake run compile',
+      pretest: 'fake run compile',
+      posttest: 'fake run check',
     };
     const pkg: PackageJson = {
       ...MINIMAL_PACKAGE_JSON,
@@ -103,13 +103,13 @@ describe('init', () => {
 
   it('addScripts should edit existing scripts on yes', async () => {
     const SCRIPTS = {
-      check: `fake check`,
+      check: 'fake check',
       clean: 'fake clean',
-      compile: `fake tsc`,
-      fix: `fake fix`,
-      prepare: `fake run compile`,
-      pretest: `fake run compile`,
-      posttest: `fake run check`,
+      compile: 'fake tsc',
+      fix: 'fake fix',
+      prepare: 'fake run compile',
+      pretest: 'fake run compile',
+      posttest: 'fake run check',
     };
     const pkg: PackageJson = {
       ...MINIMAL_PACKAGE_JSON,