Upload GRR image to GitHub container registry instead of DockerHub. #1026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panhania
requested changes
Mar 15, 2023
.github/workflows/build.yml
Outdated
| @@ -259,13 +259,14 @@ jobs: | |||
| export BRANCH=$(echo $GITHUB_REF | cut -d'/' -f 3) | |||
| ./appveyor/docker_build/build_docker_image.sh | |||
| - if: ${{ github.event_name == 'push' }} | |||
| name: Log in to Docker Hub | |||
| name: Login with Github Container registry | |||
There was a problem hiding this comment.
Nit: GitHub.
Also, from what I see, it is called "GitHub Packages", not "GitHub Container".
There was a problem hiding this comment.
I humbly disagree with the "GitHub Packages" part": https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-container-registry
There was a problem hiding this comment.
Fixed Github -> GitHub.
| - if: ${{ github.event_name == 'push' }} | ||
| name: Push to ${{ env.DOCKER_REPOSITORY }} | ||
| name: Push to GitHub Container registry |
There was a problem hiding this comment.
As said above, I think GitHub container registry is a valid term (this is what ghcr.io stands for) and what's used in the documentation.
panhania
approved these changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.