Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-center the viewport when reverting the polygon's last vertex #2458

Merged
merged 6 commits into from
May 23, 2024
Merged

Re-center the viewport when reverting the polygon's last vertex #2458

merged 6 commits into from
May 23, 2024

Conversation

shobhitagarwal1612
Copy link
Member

@shobhitagarwal1612 shobhitagarwal1612 commented May 4, 2024 •
edited

Fixes #2145

Things done:

  • Expose a new method in map fragments to allow moving the map camera on a one-off basis
  • Request moving the map camera to polygon's last known vertex
center-prev-vertex.webm

@gino-m @sufyanAbbasi PTAL?

@gino-m
Copy link
Collaborator

gino-m commented May 4, 2024

@sufyanAbbasi PTAL?

@shobhitagarwal1612
Copy link
Member Author

Gentle ping!

gino-m
gino-m approved these changes May 23, 2024
View reviewed changes
Copy link
Collaborator

@gino-m gino-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay!

@shobhitagarwal1612 shobhitagarwal1612 merged commit 48d6610 into google:master May 23, 2024
2 checks passed
@shobhitagarwal1612 shobhitagarwal1612 deleted the center-prev-vertex branch May 23, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gino-m gino-m gino-m approved these changes

@sufyanAbbasi sufyanAbbasi Awaiting requested review from sufyanAbbasi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Draw an area task] Viewport not centered on last vertex when reverting last point
2 participants
@shobhitagarwal1612 @gino-m