MediaUploadWorker: Filter on PhotoResponse. #2172
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make `path` in PhotoResponse public so that we can use it directly when uploading media. - Filter submission deltas by response value instead of task type. - Minor stylistic tweaks in trailing lambdas.
gino-m
approved these changes
Jan 10, 2024
|
@scolsen Gentle ping, this is approved but some checks are failing. |
|
@scolsen Gentle ping. Could you please fix checks so we can merge this? Also, is this a pure code health fix, or does it change user-visible behavior? When you can please link to an open issue for posterity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pathin PhotoResponse public so that we can use it directly when uploading media.@gino-m PTAL
Note that at this point we already show media upload statuses in the sync history fragment (though it may happen fast enough that one really only sees the "COMPLETED" state reported). If we want to report on the status of photos separately from their associated mutations, there's quite a bit more work to do.