Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix field visibility in objectHas for extended objects #737

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mkmik
Copy link

@mkmik mkmik commented Dec 6, 2023

Fixes #736

I added test cases.

I chose to remove the hidden field handling logic from objectHasField and instead lift it in builtinObjectHasEx because the handling of hidden fields is only necessary in the builtin implementation and not used anywhere else. It's cheaper to check if a given field exists if we don't care about handling hidden fields.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Buggy field visibility handling inobjectHas in Go impl
1 participant