Fix field visibility in objectHas for extended objects #737
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #736
I added test cases.
I chose to remove the hidden field handling logic from
objectHasField
and instead lift it inbuiltinObjectHasEx
because the handling of hidden fields is only necessary in the builtin implementation and not used anywhere else. It's cheaper to check if a given field exists if we don't care about handling hidden fields.