Skip to content

Support dismissed_review IssueEvent #827

@gmlewis

Description

@gmlewis

GitHub Developer API announcement:
https://developer.github.com/changes/2018-01-05-dismiss-event-breaking-change/

This announcement actually confuses me a bit...
From the announcement, the dismissed_review IssueEvent is changing, but I don't see any history of it, so I don't know when it was introduced. Nevertheless, we would like to support it, so it needs to be added to the IssueEvent struct in github/issues_events.go.

I think it would suffice to leave its type as a string field, similar to other states returned by this package (as opposed to strictly enumerating the values), unless there are objections.

This would be a great first issue for a new contributor to this repo or new Go developer to work on.
All help is greatly appreciated. Thank you!

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions