Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding FAO/GAEZv5/HWSDv2 to the public catalog #621

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

momegahed
Copy link

Will be followed up by an email from mohamed.megahed@fao.org

@google-cla
Copy link

google-cla bot commented Jun 13, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[FAO & IIASA. 2023. Harmonized World Soil Database version 2.0. Rome and Laxenburg.]
(https://doi.org/10.4060/cc3823en)
|||,
],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete this line.

version: '2.0',
'gee:type': ee_const.gee_type.image_collection,
description: |||
The Harmonized World Soil Database version 2.0 (HWSD v2.0) is developed by FAO and IIASA
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only indent by two more spaces than the previous line and reflow to fit in 80 columns

@@ -0,0 +1,147 @@
local id = 'FAO/GAEZv5/HWSDv2';
local subdir = 'FAO';

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add local version = '2.0';

ee_const.ext_ver,
],
id: id,
title: 'The Harmonized World Soil Database version 2.0',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

title: 'The Harmonized World Soil Database (HWSD) version ' + version,

],
id: id,
title: 'The Harmonized World Soil Database version 2.0',
version: '2.0',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

version: version,

},
'gee:terms_of_use': |||
All rights reserved. No part of this Harmonized World Soil Database may be reproduced,
stored in a retrieval system or transmitted by any means for resale or other commercial
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add this dataset to here because of the non-commercial requirement.

https://github.com/google/earthengine-catalog/blob/main/non_commercial_datasets.jsonnet

interval: 1,
},
'gee:terms_of_use': |||
All rights reserved. No part of this Harmonized World Soil Database may be reproduced,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only indent two more spaces and reflow to fit 80 columns.

bands: ['DominantSoilType'],
min: 1,
max: 34,
palette: ['ffffbe','730000','f79804','f2f2f2','40c0e9','fe0000','4b3dac','f5d4a1','8083d9','cf9804','914d35','fef400','febe00','00fefd','bd6446','fe00fa','ff8721','d4d4d4','fef6a4','706b66','383838','ca937f','d1d1d1','fa8484','ffbebe','ffa77f','fec2c2','f77d3a','0cd900','fee3a4','f9c2fe','91009d','c930fd','4752dc']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fit to 80 columns

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will also need a _preview.js script

local base_filename = basename + '.json';
local self_ee_catalog_url = ee_const.ee_catalog_url + basename;

{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first field after the opening { should be:

  // TODO(schwehr): Remove skip_indexing when the dataset is ready.
  'gee:skip_indexing': true,

See: https://github.com/google/earthengine-catalog/blob/main/catalog/TEMPLATE/TEMPLATE_IMAGE_V2_1.jsonnet#L76

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants