new elevator type #1038
Open
new elevator type #1038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shambergoldstein
requested changes
Jun 13, 2023
shambergoldstein
requested changes
Jun 16, 2023
shambergoldstein
approved these changes
Jun 16, 2023
cstirdivant
requested changes
Jun 16, 2023
|
@cstirdivant elevator_status removed and floor_status changed to floor_position_mode |
cstirdivant
requested changes
Jun 19, 2023
| @@ -3110,3 +3110,19 @@ literals: | |||
| - ultraviolet_irradiance_sensor: | |||
| fixed_min: 0.0 | |||
| flexible_max: 2000.0 | |||
|
|
|||
| - floor_position_mode: | |||
There was a problem hiding this comment.
What is the analytical benefit of knowing what floor the elevator is on? Please explain the use case more.
There was a problem hiding this comment.
ah okay. I'm not the designer and on the surface probably not much benefit but I imagine it would be useful information to know the elevator usage trends when performing data analysis on the building information down the line?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.