New tank type #1025
New tank type #1025
Conversation
| @@ -6618,3 +6618,32 @@ VMADC: | |||
| - mixed_air_damper_percentage_sensor | |||
| implements: | |||
| - CONTROL | |||
|
|
|||
| TLM: | |||
There was a problem hiding this comment.
Supply temperature points should be covered with SWTC or SWTM. Water level statuses make more sense to put on the pump, using DRPM, if possible.
| implements: | ||
| - MONITORING | ||
|
|
||
| TLM2X: |
There was a problem hiding this comment.
See above comment.
| @@ -43,3 +43,18 @@ TK_LM: | |||
| implements: | |||
| - /TK # Inherits from global namespace | |||
| - LM | |||
|
|
|||
There was a problem hiding this comment.
See comments on abstract types.
| @@ -3110,3 +3110,7 @@ literals: | |||
| - ultraviolet_irradiance_sensor: | |||
| fixed_min: 0.0 | |||
| flexible_max: 2000.0 | |||
|
|
|||
There was a problem hiding this comment.
Can you clarify what this is?
There was a problem hiding this comment.
this is to set the temperature at which an alarm will be triggered, maybe not very useful in hindsight
There was a problem hiding this comment.
If you are including the alarm point itself there is no need to include the threshold at which the alarm is triggered; so you can remove this point and the model will still be complete.
| @@ -3110,3 +3110,7 @@ literals: | |||
| - ultraviolet_irradiance_sensor: | |||
| fixed_min: 0.0 | |||
| flexible_max: 2000.0 | |||
|
|
|||
There was a problem hiding this comment.
If you are including the alarm point itself there is no need to include the threshold at which the alarm is triggered; so you can remove this point and the model will still be complete.
| - supply_water_temperature_sensor | ||
| - water_high_level_status | ||
| - water_low_level_status | ||
| - high_water_temperature_alarm |
There was a problem hiding this comment.
Please move alarms to opt_uses
| - MONITORING | ||
|
|
||
| TLM2X: | ||
| description: "Level and temperature monitoring 2x" |
There was a problem hiding this comment.
Is this intended to model two distinct tanks or a single tank with two sensors? If you are trying to model two tanks, please just apply the other type to each individual tank.
No description provided.