Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added new ahu type #1023

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

kevin-hereworks
Copy link
Contributor

No description provided.

@kevin-hereworks kevin-hereworks marked this pull request as ready for review May 15, 2023 10:25
- failed_circulation_pump_alarm_1
- failed_circulation_pump_alarm_2
- circulation_pump_speed_percentage_setpoint
- low_supply_water_temperature_alarm
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure that the temperature point is relevant for the pump's speed control.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add more details to the descriptions so that they are different from each other and more specific. A device can control based on outdoor temperature and not use this summer/winter control schema. Make it clear that the device has different setpoints based on season.

flexible_min: 255.9259259
flexible_max: 308.1481481

- season_mode:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would change this to season_command as it has only two states, or season_status if this is a feedback point.

@@ -3110,3 +3110,23 @@ literals:
- ultraviolet_irradiance_sensor:
fixed_min: 0.0
flexible_max: 2000.0

- winter_outside_temperature_setpoint:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can we have an outside air temperature setpoint? Not following this one.

flexible_min: 255.9259259
flexible_max: 322.037037

- summer_outside_temperature_setpoint:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

@@ -6618,3 +6623,69 @@ VMADC:
- mixed_air_damper_percentage_sensor
implements:
- CONTROL

SEDPM:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the use case for these on the unit you're looking at? l would not think of these as required points but perhaps they could be added as optional on existing abstract types.

implements:
- CONTROL

SEMC:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments in the fields section.

implements:
- CONTROL

HWVPM:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it has a command then it should have a sensor. See if you can use HWVM and flag your unit as missing the sensor if you don't see it.

implements:
- MONITORING

HRCM:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sensor is not very useful on it own. Do you have any of the other points in EHHRC?

implements:
- MONITORING

WDPCA2X:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide a screenshot of where you are seeing this to digitalbuildings-support@googlegroups.com if possible?

@cstirdivant cstirdivant added the ontology model Extensions or edits to the ontology model label Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ontology model Extensions or edits to the ontology model
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants