added new dwst type #1021
Open
added new dwst type #1021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shambergoldstein
requested changes
Jun 14, 2023
| @@ -140,6 +140,14 @@ PMP_SS_RMM: | |||
| - low_pressure_status | |||
| - high_pressure_status | |||
|
|
|||
| PMP_CPVSC2X_WDPC: | |||
There was a problem hiding this comment.
The entity type should refer to a single PMP, not a collection of two. Points like CPVSC2X would be used on a boiler or system.
| - heater_run_status_1 | ||
| - heater_run_status_2 | ||
| - heater_run_status_3 | ||
| - failed_alarm_1 |
There was a problem hiding this comment.
Make alarms optional.
| @@ -3110,3 +3110,7 @@ literals: | |||
| - ultraviolet_irradiance_sensor: | |||
| fixed_min: 0.0 | |||
| flexible_max: 2000.0 | |||
|
|
|||
| - heating_water_temperature_setpoint: | |||
There was a problem hiding this comment.
See above comment. Setpoint should not be on the tank itself. You should be able to use supply_water_temperature_setpoint or similar on the system instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.