Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added new ahu type #1003

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

kevin-hereworks
Copy link
Contributor

No description provided.

@kevin-hereworks kevin-hereworks marked this pull request as ready for review April 5, 2023 11:54
@mschulze17 mschulze17 added the P2 Medium priority (default) label Apr 5, 2023
- CONTROL

SFPC:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we instead use a combination of SSPM and SFC, along with maybe SFSS?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can if i add the rotational and linear velocity fields onto one of the suggested types?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment below.

- OPERATIONAL

EFPC:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we instead use ED?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use ED if i set the damper command as missing and then add the supply_fan_run_command
supply_air_linearvelocity_sensor
supply_fan_rotationalvelocity_sensor somewhere else?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevin-hereworks yes please use ED

  1. Use supply_fan_run_command by replacing SS with SFSS
  2. Use existing field supply_air_flowrate_sensor and delete supply_air_linearvelocity_sensor
  3. Add supply_fan_rotationalvelocity_sensor as optional on SFVSC (and make certain fields on that type missing, if needed)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay and then can the fire and smoke alarms be added to the sfss?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest excluding the fire and smoke alarms from this type. Typically, we see those fields modeled as part of a SAFETY system.

Additionally, there is no need for this new type EFPC at all (now that you are using ED

- OPERATIONAL

ESDC:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use a combination of EDM and SDM?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, changed

description: "fire and smoke alarm monitoring."
is_abstract: true
uses:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add as optional on SS instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@cstirdivant cstirdivant removed the request for review from tasodorff June 14, 2023 23:30
fixed_min: 0.0
flexible_max: 25.4000508

- exhaust_fan_rotationalvelocity_sensor:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is unusual to see rotationalvelocity sensors. Are there more common measures like speed_percentage or speed_frequency that are available in your system?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rotational velocity was used because the units on the reporting field are rpm, is this okay?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is OK to use rotationalvelocity if there are no speed_percentage or speed_frequency fields available in the system.

@@ -3116,3 +3116,16 @@ literals:
- ultraviolet_irradiance_sensor:
fixed_min: 0.0
flexible_max: 2000.0

- supply_air_linearvelocity_sensor:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this being measured in liters per second (or some other flowrate unit)? If so, you can use the existing field supply_air_flowrate_sensor

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its in meters per second unfortunately, we also have supply_air_flowrate_sensor on this device though

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest using supply_air_flowrate_sensor and omitting the linear velocity sensor completely (as they are functionally redundant and the flowrate sensor is more useful for downstream applications)

fixed_min: 0.0
flexible_max: 25.4000508

- exhaust_fan_rotationalvelocity_sensor:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is OK to use rotationalvelocity if there are no speed_percentage or speed_frequency fields available in the system.

is_canonical: true
implements:
- AHU
- SS
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to use SFSS here.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use SFSS and remove SS

is_canonical: true
implements:
- AHU
- SS
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to use SFSS here

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove SS and use SFSS

- OPERATIONAL

EFPC:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevin-hereworks yes please use ED

  1. Use supply_fan_run_command by replacing SS with SFSS
  2. Use existing field supply_air_flowrate_sensor and delete supply_air_linearvelocity_sensor
  3. Add supply_fan_rotationalvelocity_sensor as optional on SFVSC (and make certain fields on that type missing, if needed)

- CONTROL

SFPC:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment below.

- RMM
- RTM
- FDPM
- EFPC
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update this to use ED (and remove EFPC completely)

is_canonical: true
implements:
- AHU
- SS
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use SFSS and remove SS

is_canonical: true
implements:
- AHU
- SS
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove SS and use SFSS

@@ -3116,3 +3116,16 @@ literals:
- ultraviolet_irradiance_sensor:
fixed_min: 0.0
flexible_max: 2000.0

- supply_air_linearvelocity_sensor:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest using supply_air_flowrate_sensor and omitting the linear velocity sensor completely (as they are functionally redundant and the flowrate sensor is more useful for downstream applications)

- SFC
- HWRC
- ESDC
- FSAM
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is FSAM ? I do not see this defined in the ABSTRACT file

- SSPM
- SFC
- HWRC
- ESDC
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is ESDC? I do not see this defined in the ABSTRACT file

@@ -4100,7 +4116,22 @@ AHU_CHWSC_HWSC_ECON_EDBPC_RFSS2X_RFVSC2X_SFSS2X_SFVSC2X_SSPC:
- SFVSC2X
- SSPC


AHU_SS_SFSS_RMM_STM_FDPM_SSPM_SFC_HWRC_EDM_SDM_FSAM_SFVSC_EFVSC:
description: "AHU with supply and exhaust pressure, flowrate control, cooling and heating valve control, fire and smoke alarms supply and exhaust rotational velocity sensors"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You note that this AHU has cooling but I don't see any cooling ABSTRACT types (e.g., CHWSC, DXSC, etc.)

- RTM
- FDPM
- EFPC
- SFPC
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is SFPC? I don't see it defined in the ABSTRACT file

@@ -4069,6 +4069,22 @@ AHU_SFSS_SFMSC_SFVSC_FDPM_CHWSC_RTM_RACO2C_SSPC2X_VOADM2X_SAIDC2X_RAIDC2X_SSPC:
- RAIDC2X
- SSPC


AHU_SS_RMM_RTM_FDPM_EFPC_SFPC_HWSC_ESDC_FSAM:
description: "AHU with supply and exhaust pressure, flowrate control, cooling and heating valve control, fire and smoke alarms"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You note that this unit has cooling, but there are not any cooling ABSTRACT types applied.

@cstirdivant cstirdivant added the ontology model Extensions or edits to the ontology model label Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ontology model Extensions or edits to the ontology model P2 Medium priority (default)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants