Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin minimum version of httplib2 #262

Merged
merged 5 commits into from Sep 28, 2020
Merged

Pin minimum version of httplib2 #262

merged 5 commits into from Sep 28, 2020

Conversation

tomchop
Copy link
Collaborator

@tomchop tomchop commented Sep 28, 2020

Pin httplib2>=0.15.0 until googleapis/google-api-python-client#1050 is merged

@tomchop tomchop changed the title Gcp dependencies Pin minimum version of httplib2 Sep 28, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #262 into master will increase coverage by 2.62%.
The diff coverage is 70.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #262      +/-   ##
==========================================
+ Coverage   65.39%   68.01%   +2.62%     
==========================================
  Files          14       29      +15     
  Lines         968     1998    +1030     
==========================================
+ Hits          633     1359     +726     
- Misses        335      639     +304     
Flag Coverage Δ
#nosetests 68.01% <70.71%> (+2.62%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...cloudforensics/providers/azure/internal/network.py 24.52% <24.52%> (ø)
libcloudforensics/providers/aws/internal/kms.py 40.00% <40.00%> (ø)
libcloudforensics/providers/gcp/forensics.py 54.54% <48.00%> (-10.46%) ⬇️
libcloudforensics/providers/aws/forensics.py 56.16% <53.06%> (-13.61%) ⬇️
...ibcloudforensics/providers/gcp/internal/compute.py 56.08% <54.28%> (-6.27%) ⬇️
...cs/providers/gcp/internal/compute_base_resource.py 37.33% <54.28%> (+0.82%) ⬆️
libcloudforensics/providers/aws/internal/log.py 73.07% <55.55%> (-4.20%) ⬇️
...bcloudforensics/providers/gcp/internal/function.py 40.54% <62.50%> (+8.28%) ⬆️
...loudforensics/providers/azure/internal/resource.py 65.38% <65.38%> (ø)
...ibcloudforensics/providers/gcp/internal/project.py 61.90% <66.66%> (-3.81%) ⬇️
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 727d65e...70d97f4. Read the comment docs.

@tomchop tomchop merged commit fd955d1 into google:master Sep 28, 2020
@tomchop tomchop deleted the gcp-dependencies branch September 28, 2020 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants