Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jupyter plugin support to caliban [draft] #19

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sritchie
Copy link
Collaborator

This PR is here to begin figuring out how to do this for jupyter and jupyterlab.

@codecov
Copy link

codecov bot commented Jun 19, 2020

Codecov Report

Merging #19 into master will decrease coverage by 0.15%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
- Coverage   50.60%   50.44%   -0.16%     
==========================================
  Files          28       28              
  Lines        2897     2898       +1     
==========================================
- Hits         1466     1462       -4     
- Misses       1431     1436       +5     
Impacted Files Coverage Δ
caliban/platform/notebook.py 42.85% <0.00%> (-2.15%) ⬇️
caliban/platform/gke/util.py 70.76% <0.00%> (-1.16%) ⬇️
caliban/platform/cloud/types.py 89.47% <0.00%> (-0.66%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bd5667...adbd647. Read the comment docs.

@sritchie
Copy link
Collaborator Author

I've looked more into this, and it won't work to do what I've done in the PR! That's because you need to run jupter lab build after you change the directory.

I think we'll need to explicitly support this by adding a jupyter_plugins list to .calibanconfig, and then do this to get them installed without blowing up the base image:

jupyterlab/jupyterlab#4930

If we want to be REALLY pro, we can do a multistage build for this step. That is probably the right approach.

@sritchie sritchie changed the title Store Jupyter plugins in home directory [draft] Add Jupyter plugin support to caliban [draft] Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant