Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFCOMM: Handle packets received before DLC sink set #483

Merged
merged 1 commit into from
May 10, 2024
Merged

Conversation

zxzxwu
Copy link
Collaborator

@zxzxwu zxzxwu commented May 7, 2024

This race condition is not common since usually the initiator (no matter it's an L2CAP or RFCOMM channel) should send the first packet. However, in HFP, if it is AG opening the channel, AG cannot send the first packet, and HF may send AT+BRSF too quick that open_dlc() haven't returned yet.

@zxzxwu zxzxwu changed the title RFCOMM: Avoid receive packets before DLC sink set RFCOMM: Avoid receiving packets before DLC sink set May 7, 2024
@zxzxwu zxzxwu force-pushed the rfc branch 3 times, most recently from f169b42 to 25dedf4 Compare May 7, 2024 16:43
bumble/rfcomm.py Outdated Show resolved Hide resolved
bumble/rfcomm.py Outdated Show resolved Hide resolved
@zxzxwu zxzxwu changed the title RFCOMM: Avoid receiving packets before DLC sink set RFCOMM: Handle packets received before DLC sink set May 9, 2024
@zxzxwu zxzxwu merged commit 8781943 into google:main May 10, 2024
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants