Add condition to not populate string value if it's empty #2521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MJ1998
requested changes
Apr 29, 2024
| @@ -141,6 +141,7 @@ internal object QuestionnaireItemDialogSelectViewHolderFactory : | |||
| } | |||
| } | |||
| selectedOptions.otherOptions.map { otherOption -> | |||
| if (otherOption.isEmpty()) return@map | |||
There was a problem hiding this comment.
I think we should simply skip this case instead of returning from map!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #2520
Description
Add condition to not populate string value if it's empty
Alternative(s) considered
N/A
Type
Bug fix
Screenshots (if applicable)
Screen.Recording.2024-04-23.at.09.20.54.mov
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project../gradlew checkand./gradlew connectedCheckto test my changes locally.