Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark many things as internal #2494

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

williamito
Copy link
Contributor

@williamito williamito commented Mar 19, 2024

Description
Mark many things as internal, as they don't seem to be used by any public API. This will significantly streamline generated documentation.

Type
Code Health

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@williamito williamito requested review from santosh-pingle and a team as code owners March 19, 2024 20:59
@williamito williamito marked this pull request as draft March 19, 2024 21:15
@williamito
Copy link
Contributor Author

Switching to draft, I'm finding a lot of other things that appear to be safely marked internal

@williamito williamito marked this pull request as ready for review March 25, 2024 19:52
@williamito williamito changed the title Mark ContentTypes and MediaTypes as internal Mark many things as internal Mar 27, 2024
Copy link
Collaborator

@jingtang10 jingtang10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@santosh-pingle can you run the demo app and just check that the db is functioning as expected (don't need to spend too much time)

@aditya-07 in case you spot anything wrong here.

thanks @williamito this is fine by me as long as tests pass - nothing glaringly wrong to me.

@santosh-pingle
Copy link
Collaborator

@santosh-pingle can you run the demo app and just check that the db is functioning as expected (don't need to spend too much time)

@aditya-07 in case you spot anything wrong here.

thanks @williamito this is fine by me as long as tests pass - nothing glaringly wrong to me.

After this pull request was updated with the latest code changes (PR#2497), the upload sync was working fine, and the database was not throwing any exceptions.

@jingtang10
Copy link
Collaborator

thanks so much santosh for testing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: PR under Review
Development

Successfully merging this pull request may close these issues.

None yet

5 participants