Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FhirSyncDbInteractor #2450

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

FhirSyncDbInteractor #2450

wants to merge 3 commits into from

Conversation

MJ1998
Copy link
Collaborator

@MJ1998 MJ1998 commented Feb 26, 2024

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #2456 #2363 #2386

Introducing FhirSyncDbInteractor interface which acts as an abstract layer over database operations during sync. This is used by the FhirSynchronizer.

Now the synchronizer returns a Flow<SyncJobStatus> and is neatly invoked like following:-

val terminalSyncJobStatus =
    FhirSynchronizer(
      fhirSyncDbInteractor = fhirSyncDbInteractor,
      uploader = uploader,
      downloader = downloader,
    )
    .synchronize()
    .onEach { setProgress(buildWorkData(it)) }
    .first { it is SyncJobStatus.Failed || it is SyncJobStatus.Succeeded }

Tests not fixed yet

Description
Clear and concise code change description.

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Builds | Releases | Other)

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: New
Development

Successfully merging this pull request may close these issues.

Decoupling Sync APIs from FhirEngine for Broader Functionality
1 participant