Adds pinv to tensorflow backend (https://github.com/google/TensorNetwork/issues/844) #935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
mganahl
requested changes
Sep 7, 2021
| np.testing.assert_allclose(expected, actual) | ||
| expected = tf.linalg.pinv(tensor) | ||
| actual = backend.pinv(tensor) | ||
| np.testing.assert_allclose(expected, actual) |
There was a problem hiding this comment.
add a test that actual @ tensor and tensor @ actual equal the identity (within the desired error)
There was a problem hiding this comment.
Would testing for all the criteria in https://en.wikipedia.org/wiki/Moore%E2%80%93Penrose_inverse be a better test? (As for an example given in tf's documentation, the product wasn't identity)
| @@ -430,3 +430,26 @@ def eps(self, dtype: Type[np.number]) -> float: | |||
| float: Machine epsilon. | |||
| """ | |||
| return tf.experimental.numpy.finfo(dtype).eps | |||
|
|
|||
| def pinv(self, tensor: Tensor, rcond: float = 1E-15, hermitian: bool = False) -> Tensor: | |||
There was a problem hiding this comment.
I think you can remove the hermitian argument
There was a problem hiding this comment.
I had included it as it was an argument for numpy. I'll remove it in the next commit.
Thanks for the review!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added pinv to tensorflow_backend.py and corresponding tests to tensorflow_backend_tests,py Issue: #844