Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export typing information #923

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

JanLuca
Copy link

@JanLuca JanLuca commented May 20, 2021

This commit adds the flag that the package contains typing
information. Therefore other packages can use the typing data to check their
code by mypy.

Ref.: https://mypy.readthedocs.io/en/stable/installed_packages.html#making-pep-561-compatible-packages

Signed-off-by: Jan Luca Naumann j.naumann@fu-berlin.de

This commit adds the flag that the package contains typing
information. Therefore other packages can use the typing data to check their
code by mypy.

Ref.: https://mypy.readthedocs.io/en/stable/installed_packages.html#making-pep-561-compatible-packages

Signed-off-by: Jan Luca Naumann <j.naumann@fu-berlin.de>
@google-cla
Copy link

google-cla bot commented May 20, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label May 20, 2021
@JanLuca
Copy link
Author

JanLuca commented May 20, 2021

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels May 20, 2021
Copy link
Collaborator

@alewis alewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mganahl
Copy link
Collaborator

mganahl commented May 31, 2021

Thanks for the PR! I'll fix the build and merge this.

@codecov-commenter
Copy link

Codecov Report

Merging #923 (357f430) into master (20dc783) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #923   +/-   ##
=======================================
  Coverage   98.04%   98.04%           
=======================================
  Files         129      129           
  Lines       22394    22394           
=======================================
  Hits        21957    21957           
  Misses        437      437           
Impacted Files Coverage Δ
setup.py 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20dc783...357f430. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants