Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added pinv to tensorflow backend #917

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

raunakbhupal
Copy link

This is done with respect to issue: #844
pinv function is added to tensornetwork/backends/tensorflow/tensorflow_backend.py
The pinv function has been referred from https://numpy.org/doc/stable/reference/generated/numpy.linalg.pinv.html
Please do have a look and let me know if should make any other change.
Thank you.

@google-cla
Copy link

google-cla bot commented Apr 1, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Apr 1, 2021
@raunakbhupal
Copy link
Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Apr 1, 2021
@raunakbhupal
Copy link
Author

@alewis Can you please review this and let me know if there are any changes to be made?

@codecov-io
Copy link

codecov-io commented Apr 2, 2021

Codecov Report

Merging #917 (14016a1) into master (6ac507a) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #917      +/-   ##
==========================================
- Coverage   98.12%   98.11%   -0.01%     
==========================================
  Files         129      129              
  Lines       22790    22792       +2     
==========================================
+ Hits        22362    22363       +1     
- Misses        428      429       +1     
Impacted Files Coverage Δ
...rnetwork/backends/tensorflow/tensorflow_backend.py 97.68% <50.00%> (-0.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ac507a...14016a1. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants