Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SU(2) Exact Diagonalization #898

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

SU(2) Exact Diagonalization #898

wants to merge 5 commits into from

Conversation

qsukhi
Copy link

@qsukhi qsukhi commented Jan 12, 2021

Added a function to compute the low energy eigenstates of a local, SU(2)-symmetric Hamiltonian, in a way that exploits the SU(2) symmetry. Also added some generic SU(2) functionality e.g. functions to compute Clebsch-Gordan coefficients, Fusion Rules, Fusing two indices etc.

Added a function to compute the low energy eigenstates of a local, SU(2)-symmetric Hamiltonian, in a way that exploits the SU(2) symmetry. Also added some generic SU(2) functionality e.g. functions to compute Clebsch-Gordan coefficients, Fusion Rules, Fusing two indices etc.
@google-cla
Copy link

google-cla bot commented Jan 12, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Jan 12, 2021
@qsukhi
Copy link
Author

qsukhi commented Jan 12, 2021

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Jan 12, 2021
@mganahl
Copy link
Collaborator

mganahl commented Jan 12, 2021

thanks @qsukhi I'll take a look!

@mganahl
Copy link
Collaborator

mganahl commented Jan 14, 2021

Hi @qsukhi, I'm working through the code. It will take me a bit of time since it is a lot of code. In the meantime, can you change indenting to two spaces instead of four? I wonder why the linter didn't catch this.
Also, I noticed that there is a binary file in this PR, is this intentional?

@qsukhi
Copy link
Author

qsukhi commented Jan 19, 2021

Thanks, @mganahl.
-I've reduced the indent to 2 spaces.
-The binary file is a table of factors that come from the Clebsch-Gordan part of SU(2)-symmetric tensor contractions. It is not necessary, as the function Su2ExactDiagonalization() can build the factor tables if the user specifies so (as illustrated in Su2ExactDiagonalization/main.py).

@codecov-io
Copy link

codecov-io commented Jan 27, 2021

Codecov Report

Merging #898 (e1be4b0) into master (523e7a8) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #898      +/-   ##
==========================================
- Coverage   98.12%   98.08%   -0.05%     
==========================================
  Files         129      129              
  Lines       22790    22257     -533     
==========================================
- Hits        22362    21830     -532     
+ Misses        428      427       -1     
Impacted Files Coverage Δ
...ornetwork/matrixproductstates/infinite_mps_test.py 84.78% <0.00%> (-1.50%) ⬇️
...ckends/tensorflow/tensorflow_tensornetwork_test.py 59.75% <0.00%> (-1.17%) ⬇️
tensornetwork/linalg/tests/initialization_test.py 84.61% <0.00%> (-0.65%) ⬇️
tensornetwork/backends/decorators_test.py 92.64% <0.00%> (-0.51%) ⬇️
...ensornetwork/tests/tensornetwork_symmetric_test.py 92.70% <0.00%> (-0.37%) ⬇️
tensornetwork/backends/decorators.py 96.77% <0.00%> (-0.20%) ⬇️
tensornetwork/linalg/tests/test_linalg.py 96.31% <0.00%> (-0.20%) ⬇️
tensornetwork/tests/tensor_test.py 98.51% <0.00%> (-0.15%) ⬇️
examples/simple_mera/simple_mera.py 95.49% <0.00%> (-0.12%) ⬇️
...tractors/opt_einsum_paths/path_calculation_test.py 95.74% <0.00%> (-0.09%) ⬇️
... and 44 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 523e7a8...e1be4b0. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants