Feature/pytorch backend #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng methods separately did not work
Closed
| @@ -160,7 +160,7 @@ additional-builtins= | |||
| ignore-mixin-members=yes | |||
| # List of classes names for which member attributes should not be checked | |||
| # (useful for classes with attributes dynamically set). | |||
| ignored-classes=SQLObject,twisted.internet.reactor,hashlib,google.appengine.api.memcache | |||
| ignored-classes=SQLObject,twisted.internet.reactor,hashlib,google.appengine.api.memcache,torch | |||
There was a problem hiding this comment.
Any reason you added this?
There was a problem hiding this comment.
It is to fix this issue: pytorch/pytorch#701
I tried adding the separate functions that are used only, but for some reason that didn't work, so I reverted to the proposed solution of adding the full toch library. Tbh, I'm not 100% happy with this either.
…ature/pytorch-backend
This reverts commit 2e8bf33
chaserileyroberts
approved these changes
Jul 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First attempt to add PyTorch backend, expect a lot of comments & input on this PR and there is no hurry as I might not have time to address those quickly. Consider this a first check of progress.