Process authorization response and token fetch. #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…resentAuthorizationRequest
…st strict mocks to less restrictive. Also, fix nullability warnings in GIDFakeMainBundle.
… pass a configuration.
… sign-in and verify flow.
…amorales/processAuthorizationResponse
…resentAuthorizationRequest
mdmathias
requested changes
May 20, 2024
GoogleSignIn/Sources/GIDVerifyAccountDetail/Implementations/GIDVerifyAccountDetail.m
Outdated
Show resolved
Hide resolved
GoogleSignIn/Sources/Public/GoogleSignIn/GIDVerifyAccountDetail.h
Outdated
Show resolved
Hide resolved
GoogleSignIn/Sources/Public/GoogleSignIn/GIDVerifyAccountDetail.h
Outdated
Show resolved
Hide resolved
mdmathias
requested changes
May 30, 2024
GoogleSignIn/Sources/GIDAuthorizationResponse/Fake/GIDAuthorizationResponseHandlingFake.h
Show resolved
Hide resolved
GoogleSignIn/Sources/GIDAuthorizationResponse/GIDAuthorizationResponseHelper.m
Outdated
Show resolved
Hide resolved
GoogleSignIn/Sources/GIDAuthorizationResponse/Implementations/GIDAuthorizationResponseHandler.h
Show resolved
Hide resolved
GoogleSignIn/Sources/GIDAuthorizationResponse/Implementations/GIDAuthorizationResponseHandler.m
Outdated
Show resolved
Hide resolved
GoogleSignIn/Sources/GIDAuthorizationResponse/API/GIDAuthorizationResponseHandling.h
Outdated
Show resolved
Hide resolved
mdmathias
requested changes
Jun 4, 2024
GoogleSignIn/Sources/GIDAuthorizationResponse/API/GIDAuthorizationResponseHandling.h
Outdated
Show resolved
Hide resolved
GoogleSignIn/Sources/GIDAuthorizationResponse/Implementations/GIDAuthorizationResponseHandler.h
Outdated
Show resolved
Hide resolved
GoogleSignIn/Sources/GIDAuthorizationResponse/Implementations/GIDAuthorizationResponseHandler.m
Outdated
Show resolved
Hide resolved
GoogleSignIn/Sources/GIDAuthorizationResponse/Implementations/GIDAuthorizationResponseHandler.m
Outdated
Show resolved
Hide resolved
mdmathias
reviewed
Jun 5, 2024
mdmathias
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once an instance of
OIDAuthorizationRequestis made to start the incremental authorization flow, next step is to process the response made from this request. This is done similar to the interactive sign in flow. VwG adds an instance method-[GIDVerifyAccountDetail processAuthorizationResponse:error:]checking for whether or not the authorization response has an authorization code. Testing will be done in a future PR once the response has been handled.