New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check bundle optional for localized string #373

Open

nrurnru wants to merge 1 commit into google:main from nrurnru:localizedstring-bundle-optional

nrurnru commented Feb 29, 2024 •

edited

resolve #309

Add optional check for bundle of framework.
In this case UIAlertAction occurred crash because localizedStringForKey returned nil.

Swift version already has check this way.

GoogleSignIn-iOS/GoogleSignInSwift/Sources/GoogleSignInButtonStrings.swift

Line 41 in b45a837

guard let frameworkBundle = Bundle.gidFrameworkBundle() else { return text }


          Check bundle optional for localized string

546e46a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment