Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bash script to run all data preprocessing #32

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nik-sm
Copy link

@nik-sm nik-sm commented Jan 28, 2020

Thanks for making this project open source.

Since it took some time to manually follow the data preprocessing instructions that you provided, I found it useful to write a single bash script to run all the preprocessing, and thought this might be convenient for others as well.

I also found that some minor changes to requirements.txt were necessary.

If this script would be more useful with changes, please let me know and I'll be happy to modify.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no Author has not signed CLA label Jan 28, 2020
@nik-sm
Copy link
Author

nik-sm commented Jan 28, 2020

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes Author has signed CLA and removed cla: no Author has not signed CLA labels Jan 28, 2020
@lamblin
Copy link
Collaborator

lamblin commented Apr 1, 2020

Thanks for the contribution!
I would prefer to keep the minimum of files in the root of the repo, do you think there would be a way of making the script work from inside meta_dataset/dataset_conversion/ for instance?
Also, could you add a pointer to that script and how to use it in doc/dataset_conversion.md, and maybe mention it in README.md as well?

Base automatically changed from master to main January 23, 2021 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Author has signed CLA
Development

Successfully merging this pull request may close these issues.

None yet

3 participants