Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sometimes changes to the draggable prop don't get propagated #994

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tagoro9
Copy link

@tagoro9 tagoro9 commented Jan 30, 2021

This pull request fixes an issue where a change to the draggable prop would not make the map draggable by not omitting the prop inside the shouldComponentUpdate prop.

If we change the prop but there is no other prop change the map behavior won't get updated, as that is done inside the componentDidUpdate function.

You can see the issue reproduced in this sandbox: https://codesandbox.io/s/distracted-wright-hrs51?file=/src/App.js

When you make the map draggable only the last map becomes draggable as there is another prop change, while the first 2 can't be dragged (the second one is expected as the code in componentDidUpdate omits those).

Fixes #978

return (
!shallowEqual(

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to be working well for me

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's still not working for me. Does the sandbox in the PR description work for you?

When I check the draggable checkbox at the top, only the third map becomes draggable, but not the first two. I would expect these 2 to also be draggable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Map options are not being updated.
2 participants