New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for mapId option. #1086
base: master
Are you sure you want to change the base?
Conversation
Hello @itsmichaeldiego, I'm reaching out to see if you could take a look at this PR. It's enabling mapId support inside map options. Thanks in advance! |
@jakeFeldman: Awesome! I really need this as I want to use such a map style by map ID! |
@jakeFeldman: Also note that the mapId can only be changed (after it was set) by completely resetting the Google Maps instance (see https://stackoverflow.com/a/62947623/4150808). |
I need this PR as well. I hope it's merged to the main. Is this project not active anymore? It seems like it's been a while since the PR was created. |
Not too sure. Doesn't seem like its maintained anymore. |
Waiting for this to be merged! Would be a good feature. |
options = omit(options, ['styles']); | ||
} | ||
|
||
console.log('options', options); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should remove this
Description
This PR adds support for mapId. By default
mapId
works by adding to the options prop, but we get a warning in the console. This resolves said warning by removing the styles property from the maps option.I've updated the type defs in the DefinitelyTyped repo as well (PR here)
closes #1070